-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom Duration and Timestamp types for conversion with serde #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fore5fire
force-pushed
the
serde-datetime
branch
from
October 13, 2024 04:43
0c082ac
to
155548e
Compare
clarkmcc
requested changes
Oct 17, 2024
I did some research and found the clever idea to use serde's newtype_struct name field as the indicator to do special type handling. Since serde's official recommendation is to silently unwrap newtypes, it's a great way to signal to a custom Serializer but remain compatible with most other implementations |
fore5fire
force-pushed
the
serde-datetime
branch
from
October 19, 2024 04:16
28b67cb
to
62ea6f2
Compare
fore5fire
force-pushed
the
serde-datetime
branch
from
October 19, 2024 16:22
1222943
to
18ddbb6
Compare
Updated for the new |
clarkmcc
requested changes
Oct 29, 2024
clarkmcc
approved these changes
Nov 19, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
chrono::Duration
doesn't implementSeralize
andchrono::DateTime
serializes to an ISO 8601 string. This change is inspired by the toml crate's approach to preserving date formats across functions available in theSerialize
trait to ensure that durations and timestamp are converted into the appropriate CEL types.Using the newly exposed
Duration
andTimestamp
types is only necessary for types usingserde
to convert to CEL, but maybe it could be confusing to keep track of where to use thechrono
types vs thecel_interpreter
types? But it seems like an unnecessary breaking change to use the new types inValue::Duration
andValue::Timestamp
🤷🏼