Upgrade eslint; fix some new warnings and disable others #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades eslint and related packages to the latest versions available. This fixes three of the bitHound dependency tests (#148). I will be preparing another PR to deal with the remaining five tests, but since this is a fairly far-reaching set of changes, I wanted this one to be reviewed separately.
New warnings either in eslint or in eslint-config-airbnb-base were subsequently triggered and resolved as follows:
exports
andinternals
simultaneously using chained assignments (a = b = c;
). IMO, this is useful and makes the code clearer.a => { }
forms changed to(a) => { }
)new Buffer(...)
forms toBuffer.from(...)
.a - b * c
, grouping likea - (b * c)
makes the author's intent clear, even though that's what's happening anyway.)x++
forms tox += 1
.typeof(x)
forms totypeof x
.x.hasOwnProperty(y)
forms withObject.prototype.hasOwnProperty.call(x, y)
.x.__defineGetter__()
forms with equivalentObject.defineProperty()
calls.\
characters in string literals.