HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w…

…ith an uncaught exception (apache#2079) Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Josh Elser <[email protected]>
clarax · Jul 17, 2020 · bd42c75 · bd42c75
1 parent 1781185
commit bd42c75
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java
@@ -348,8 +348,14 @@ public void saslReadAndProcess(ByteBuff saslToken) throws IOException,
       byte[] replyToken;
       try {
         if (saslServer == null) {
-          saslServer =
+          try {
+            saslServer =
               new HBaseSaslRpcServer(provider, rpcServer.saslProps, rpcServer.secretManager);
+          } catch (Exception e){
+            RpcServer.LOG.error("Error when trying to create instance of HBaseSaslRpcServer "
+              + "with sasl provider: " + provider, e);
+            throw e;
+          }
           RpcServer.LOG.debug("Created SASL server with mechanism={}",
               provider.getSaslAuthMethod().getAuthMethod());
         }