Multiple minor improvements #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one is *not* identical to 0-13-15: it adds the electric-energy-interface. This resolves #1.
Warning: ModalPortal: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.
We need a development webserver to view the calculator locally, because it does AJAX requests and those don't work over the file:// protocol. This repo is just a collection of static files, so there was no platform yet that could act as a webserver. I've decided to go for ruby because that is what github pages uses if you want more than just static files. https://help.github.com/articles/using-jekyll-as-a-static-site-generator-with-github-pages/
https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.createclass Warning: Datasource: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement. This also required some updates the way event handlers are bound to `this`. https://facebook.github.io/react/docs/handling-events.html
Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of `Explain`. See https://fb.me/react-warning-keys for more information. in div (created by Explain)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've accumulated these on my fork, and I thought these would improve your main fork also. 😃