Replace .getManifest() call #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…precated by shaka using now getPresentationStartTimeAsDate()
leticiafernandes
requested review from
joaopaulovieira and
jhonatangcavalcanti
and removed request for
joaopaulovieira
…er playbacks (like hls)
jhonatangcavalcanti
approved these changes
Jun 14, 2021
leandromoreira
approved these changes
Jun 14, 2021
joaopaulovieira
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
getManifest()method was deprecated by Shaka and was generating a ton of warnings at the DevTools console.Shaka has a method to access directly the presentation start time (
getPresentationStartTimeAsDate) and this PR is responsible for it's implementation.Changes
clappr-dash-shaka-playback.js- Fix retrieving of presentation start time as a date.How to test
LIVEmedia;_onTimeUpdatemethod;firstFragDateTimekey should be passed correctly and without warnings at the application console.VoDmedias the sended value should be0.A picture is worth a thousand words
Before
After