fix(complete): Escape special characters properly for zsh #4848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Apr 19, 2023
changhc
force-pushed
the
fix-escape-zsh
branch
3 times, most recently
from
3b6c4c0 to
709602a
Compare
epage
reviewed
Apr 20, 2023
Signed-off-by: Huan-Cheng Chang <[email protected]>
|
Sorry, forgot to release this. Its now out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4751.
The original problem is because of unescaped colons, which is included in this PR. However, there are other characters that might cause similar issues, such as backticks and dollar signs. I don't think one would expect something like
$PATHto be expanded when he or she puts it in a helper string.Added a few test cases for unit testing. I think we should add integration tests for this, i.e., help strings from comments, but I'm not sure how to do it.