Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one-error in ArgGroup printing #477

Closed
wants to merge 1 commit into from

Conversation

panicbit
Copy link
Contributor

Closes #476

@yo-bot
Copy link

yo-bot commented Apr 10, 2016

Thanks for the pull request, and welcome! The team is excited to review your changes, and you should hear from @Vinatorul (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kbknapp kbknapp mentioned this pull request Apr 10, 2016
@kbknapp
Copy link
Member

kbknapp commented Apr 10, 2016

The fail was caused by some old no longer needed tests. I've removed them and rebased onto your fork-branch in #479 so you still get credit for the commit.

Thanks for finding, filing and fixing this 👍

@kbknapp kbknapp closed this Apr 10, 2016
homu added a commit that referenced this pull request Apr 10, 2016
homu added a commit that referenced this pull request Apr 10, 2016
homu added a commit that referenced this pull request Apr 11, 2016
homu added a commit that referenced this pull request Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants