fix: remove strict linting from generated code #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MingweiSamuel
force-pushed
the
nodeny
branch
from
5989cf2 to
fa76f6f
Compare
|
Agreed that we shouldn't make the lints stricter. We have CI to make sure that any lints that are generated get denied. |
3 tasks
2 tasks
hds
added a commit
to hds/clap
that referenced
this pull request
Apr 25, 2023
The `#[deny(correctness)]` attribute is inside some generated code (such as the `Subcommand` derive macro). As of Rust 1.69.0, this is triggering a clippy error in some uses. Due to the placement of the `deny`, it is not possible for a user of clap to override it. This change removes all the instances of this `deny` attribute. The same was done on the `master` branch in clap-rs#4739. Fixes: 4857
hds
added a commit
to hds/clap
that referenced
this pull request
Apr 25, 2023
The `#[deny(correctness)]` attribute is inside some generated code (such as the `Subcommand` derive macro). As of Rust 1.69.0, this is triggering a clippy error in some uses. Due to the placement of the `deny`, it is not possible for a user of clap to override it. This change removes all the instances of this `deny` attribute. The same was done on the `master` branch in clap-rs#4739. Fixes: clap-rs#4857
hds
added a commit
to hds/clap
that referenced
this pull request
Apr 25, 2023
The `#[deny(correctness)]` attribute is inside some generated code (such as the `Subcommand` derive macro). As of Rust 1.69.0, this is triggering a clippy error in some uses. Due to the placement of the `deny`, it is not possible for a user of clap to override it. This change removes all the instances of this `deny` attribute. The same was done on the `master` branch in clap-rs#4739. Fixes: clap-rs#4857
hds
added a commit
to hds/clap
that referenced
this pull request
Apr 25, 2023
The `#[deny(correctness)]` attribute is inside some generated code (such as the `Subcommand` derive macro). As of Rust 1.69.0, this is triggering a clippy error in some uses. Due to the placement of the `deny`, it is not possible for a user of clap to override it. This change removes all the instances of this `deny` attribute. The same was done on the `master` branch in clap-rs#4739. Fixes: clap-rs#4857
This was referenced May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4733
Removes
#[deny(clippy::correctness)]from generated code, added in #1726Macros really shouldn't be making lints stricter, just causes more noise in user code when they're triggered. Macro code naturally will have lint false positives