Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Broken long arg inference on conflicts #4584

Closed
wants to merge 1 commit into from
Closed

fix: Broken long arg inference on conflicts #4584

wants to merge 1 commit into from

Conversation

SUPERCILEX
Copy link
Contributor

Long args would pick a random arg upon conflict.


About size stuff: the vec implementation is actually bigger. Vec: 773.5 KiB. Iterator: 772.9 KiB.

@epage
Copy link
Member

epage commented Jan 3, 2023

Closing as this was split out of #4583 and an issue was requested before a PR

@epage epage closed this Jan 3, 2023
@SUPERCILEX
Copy link
Contributor Author

If you'd like to file an issue for me, go for it, but I will not be wasting my time when there is an obvious bug with a simple solution that's unit tested. If you end up including these commits (or any part of them), please make sure they are authored (or co-authored) by "Alex Saveau [email protected]".

@epage
Copy link
Member

epage commented Jan 3, 2023

The point of creating issues is for communication, to make sure we understand and agree on the problem and solution before focusing on the code.

@SUPERCILEX
Copy link
Contributor Author

@epage is the issues-first policy still a thing or can these two PRs be reopened? Saw your release today and it'd be nice to get off of my fork.

@epage
Copy link
Member

epage commented Mar 29, 2023

Nothing has changed about needing an Issue as a place for us to communicate and make sure we understand and agree on the problem and the solution.

@SUPERCILEX
Copy link
Contributor Author

Ok, I've got a bit of extra time this quarter: #4603 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants