Scopewide attributes #377
Merged
Scopewide attributes #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kbknapp (yo-bot has picked a reviewer for you, use r? to override) |
|
Great point! @homu r+ |
|
📌 Commit 3936b28 has been approved by |
homu
added a commit
that referenced
this pull request
Jan 12, 2016
Scopewide attributes For `tests/yaml.rs`, it makes sense to use scope wide attribute, which applies to the whole file, because yaml test will not be tested without yaml feature. For `examples/17_yaml.rs`, I moved the `use` statement inside so that seemingly random unused import warning doesn't pop up. For `tests/unicode.rs`, well, I tried fiddling around with unicode with Windows without much success...
homu
added a commit
that referenced
this pull request
Jan 12, 2016
Scopewide attributes For `tests/yaml.rs`, it makes sense to use scope wide attribute, which applies to the whole file, because yaml test will not be tested without yaml feature. For `examples/17_yaml.rs`, I moved the `use` statement inside so that seemingly random unused import warning doesn't pop up. For `tests/unicode.rs`, well, I tried fiddling around with unicode with Windows without much success...
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
tests/yaml.rs, it makes sense to use scope wide attribute, which applies to the whole file, because yaml test will not be tested without yaml feature.For
examples/17_yaml.rs, I moved theusestatement inside so that seemingly random unused import warning doesn't pop up.For
tests/unicode.rs, well, I tried fiddling around with unicode with Windows without much success...