fix(error): Never show unrequested color

[epage]

If the user prints a raw error, it may include color even if the user
turned it off at runtime. Now we'll be more conservative and never show
color for raw errors.

This is a follow up to #2943; apparently I had missed some cases.

[pksunkara]

This should be okay for now but ideally we would want all these errors to read the color from the app.

I tried looking into doing that a week or 2 ago, but it wasn't easy enough and might need a bit more refactor.

bors r+

[epage]

This should be okay for now but ideally we would want all these errors to read the color from the app.

I tried looking into doing that a week or 2 ago, but it wasn't easy enough and might need a bit more refactor.

The new Error::format API helps. We can make it so ColorChoice is set on the Colorizer as Error::format time. I'm already doing something similar for WaitOnError to unify the exit experiences. This requires the user to explicitly keep their app and do Error::format.

The parser/validator proposal will also help because it will move the value_of_t errors earlier in the process where the App still exists.

[pksunkara]

The parser/validator proposal will also help because it will move the value_of_t errors earlier in the process where the App still exists.

That's what I was thinking too

[bors]

Build succeeded:

• CI