-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Clarify corner caseses with default values #2896
Conversation
I disagree with this. The initial implementation was very buggy because of incomplete design. We had fixed many of those bugs for v3 but it still behaves wrongly because of the original design. What we need is a tiny bit refactor on the design for how this works to solve the linked issue. This is actually one of the reason why I have all those default value related issues marked as 3.0 (Let's keep continuing to discuss the deferral part in other places). They will all be fixed by this design refactor. |
That is best discussed in the Issue. |
I looked at #2897 a bit more and I think I can get it done by the end of upcoming weekend. Let's wait on merging this until then. |
I'd rather we not keep a branch long-lived for the sake of a possibility. If you end up fixing this, it can be reverted then. |
Give me a few days as I asked. It's not long. I lose track of things that need reverts when I fix them. |
This is meant to lower the chance of confusion with cases like clap-rs#2714 and clap-rs#1586. This is not meant to be exhaustive, looked at the mentioned cases in that issue and pattern matched on other ones mentioning "is present".
We don't add documentation when it is a big fix right? |
We are documenting a pitfall within the current behavior. If/when that pitfall is removed, we can update it. |
Build succeeded: |
This is meant to lower the chance of confusion with cases like #2714 and #1586
This is not meant to be exhaustive, looked at the mentioned cases in
that issue and pattern matched on other ones mentioning "is present".
When working on this, I wanted to make sure we limit our
**NOTE:**
s to not lower their value, so I moved the YAML description down into the examples which seems more fitting and some cases already do this.