Failing tests for 1010 #1072
Closed
Failing tests for 1010 #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@willmurphyscode, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbknapp to be a potential reviewer. |
|
@willmurphyscode Yeah, the code looks good for me. Are you working on resolving this issue? |
|
I think the added tests might be for #1010 whereas #1061 deals with flags specifically which aren't handled in the propagating of values because there is no value to be propagated. To fix #1061 we'd just need to add some logic to propagate whether the flag was used or not and number of occurrences. I'd recommend renaming this PR to reflect working on #1010 and open a new PR for #1061 to handling propagating of flags. |
|
@Freyskeyd that'd be great thanks! |
|
Closing in favor of #1075 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains failing tests that demonstrate #1010.
I will try to make the tests pass, but I wanted a little input from @kbknapp on how to proceed, and I wanted to make sure @Freyskeyd believes that these tests reproduce the issue he reported correctly.
This change is
Changed by @kbknapp to change to reference #1010