default to log level info

[yoshuawuyts]

Defaults to log level info and adds a --quiet flag. Closes #10. Closes #9. Thanks!

[epage]

Another option is to allow repeated --quiet. It might not be obvious that to be completely quiet you need -qq.

[yoshuawuyts]

Oh yeah, that's a cool suggestion! If that were the case we should also make the flags exclusive by putting them in a group. I don't know which one is better though. What do you think?

[epage]

I can go either way. Both can have confusing situations and there is consensus on q/v existing but not how to handle multiple logging levels.

btw here is my python code I've been using for 5-10 years

# We want to default to WARNING
# Verbosity gives us granularity to control past that
if 0 < args.verbose and 0 < args.quiet:
    parser.error("Mixing --verbose and --quiet is contradictory")
verbosity = 2 + args.quiet - args.verbose
verbosity = max(verbosity, 0)
verbosity = min(verbosity, 4)
args.logging_level = {
    0: logging.DEBUG,
    1: logging.INFO,
    2: logging.WARNING,
    3: logging.ERROR,
    4: logging.CRITICAL,
}[verbosity]

[killercup]

Okay, this does two things (in one commit…). Let me comment on each one because I feel like we should discuss this before we make these quite essential changes.

1. -q. I agree it's a good idea – but I'd very much expect this to conflict with passing -v!
2. Default to "info" level. This is surprising. I can see reasons for "warn", but "info"? Which app in the wild defaults to info?

Both together: If you were to default to warn, -q could be used to only show errors. (The log crate doesn't have a "critical" level.)

[epage]

Default to "info" level. This is surprising. I can see reasons for "warn", but "info"? Which app in the wild defaults to info?

If people are using INFO as user-facing information messages, e.g. in place of println!, and not another DEBUG/TRACE level, I can see it being reasonable. I originally defaulted to WARN (like in my python snippet above) but as I've matured in my logging use, I've been leaning more towards INFO being a default.

An example of me using INFO: https://github.com/cobalt-org/cobalt.rs/blob/master/src/bin/cobalt/serve.rs#L136

[epage]

I have a PR that at least makes the log level configurable

See #18