Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-morpho-chan-vese #311

Merged
merged 11 commits into from
Jul 2, 2024
Merged

Add-morpho-chan-vese #311

merged 11 commits into from
Jul 2, 2024

Conversation

StRigaud
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 46.66667% with 48 lines in your changes missing coverage. Please review.

Project coverage is 47.43%. Comparing base (39e8f92) to head (3d6832b).
Report is 10 commits behind head on master.

Files Patch % Lines
clic/src/tier3/morphological_chan_vese.cpp 43.24% 4 Missing and 38 partials ⚠️
clic/src/tier1/binary_infsup.cpp 62.50% 0 Missing and 3 partials ⚠️
clic/src/tier1/binary_supinf.cpp 62.50% 0 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
- Coverage   47.46%   47.43%   -0.03%     
==========================================
  Files         232      235       +3     
  Lines        3032     3122      +90     
  Branches     1493     1548      +55     
==========================================
+ Hits         1439     1481      +42     
- Misses        411      415       +4     
- Partials     1182     1226      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StRigaud StRigaud marked this pull request as ready for review June 26, 2024 16:40
@StRigaud
Copy link
Member Author

The kernel sup_inf and inf_sup only work on uint8 type buffer because we are using a specific read function only working on uint8 datatype.

This can be limiting over time and a better implementation of the kernels should be done. This may requires to update the preamble.

@StRigaud
Copy link
Member Author

Test of the morphological chan vese fail because of the smoothing step that is not exactly the same as for scikit image. Something is off and can't find it yet.

@StRigaud StRigaud merged commit 7342c2f into master Jul 2, 2024
5 checks passed
@StRigaud StRigaud deleted the add-morpho-chan-vese branch July 2, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants