Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some suggestions #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Some suggestions #2

wants to merge 2 commits into from

Conversation

sfambach
Copy link

@sfambach sfambach commented Oct 14, 2020 •
edited
Loading

Hi,

i have done only minor changes:

  • changed DEEPSLEEP_SECONDS from int to uint64_t, if we use int there is an overload by less than one day, and if the user takes bigger number it will never sleep.
  • I put some of the settings from the main file to the credentials to have them in one place
  • I made titles switchable, sorry for the german langugage, if needed i can translate them

hopefully this suggest will find your acceptance

@sfambach
Update credentials.h
97bd5c6 
I changed the type of DEEPSLEEP_SECONDS to uint64_t if you use int there is an overload by less than one day. 
I have removed the settings from The hiGrowESP32MQTT file to this settings file to have all in the same file.
@sfambach
Update HiGrowESP32MQTT.ino
6d64435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfambach