feat: add in a sonatypeHost setting and Pom checks #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intended use for this would be that all new people using the so1 hostname don't need to do this: ``` override def sonatypeUri = "https://s01.oss.sonatype.org/service/local" override def sonatypeSnapshotUri = "https://s01.oss.sonatype.org/content/repositories/snapshots" ``` And they can instead just do: ``` override def sonatypeHost = SonatypeHost.s01 ``` And it will set the correct `sonatypeUri` and `sonatypeSnapshotUri`. I wanted to make s01 default, but this would break for people that have it set up already using legacy host, and I see some that are using it with that.
It looks like if you don't have a license set and at least one developer listed in your `PomSettings` then when you try to publish Sonatype will just silently fail. This adds in a check for both of those situations.
ckipp01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intended use for this would be that all new people using the so1
hostname don't need to do this:
And they can instead just do:
And it will set the correct
sonatypeUriandsonatypeSnapshotUri. Iwanted to make s01 default, but this would break for people that have it
set up already using legacy host, and I see some that are using it with
that.
It looks like if you don't have a license set and at least one developer
listed in your
PomSettingsthen when you try to publish Sonatype willjust silently fail. This adds in a check for both of those situations.