Fixed image resizer for images with links #8809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
reviewed
Jan 12, 2021
| // The resizer must be attached only to images loaded by the `ImageInsert` or `ImageUpload` plugins. | ||
| if ( !domEvent.target.matches( 'figure.image.ck-widget > img' ) ) { | ||
| // The resizer must be attached only to images loaded by the `ImageInsert`, `ImageUpload` or `LinkImage` plugins. | ||
| if ( !domEvent.target.matches( 'figure.image.ck-widget > img, figure.image.ck-widget > a > img' ) ) { |
There was a problem hiding this comment.
I know that I suggested this solution, but I'm wondering now if we could check if this img DOM node has a mapping to view and model elements. WDYT?
There was a problem hiding this comment.
Hmm, no idea what kind of consequences this change will have and whether it covers all cases...
There was a problem hiding this comment.
Hmm seems that img element itself has no mapping to model element. Ok let's leave it this way for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (image): Fixed image resizer for images with links. Closes #8749.