Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolbarLineBreakView should not be rendered when grouping is enabled. #8656

Merged
merged 3 commits into from
Dec 15, 2020

Conversation

maxbarnas
Copy link
Contributor

@maxbarnas maxbarnas commented Dec 14, 2020

Suggested merge commit message (convention)

Fix (ui): A '-' divider will not be rendered when grouping is enabled. Closes #8582.

@maxbarnas maxbarnas marked this pull request as ready for review December 14, 2020 13:16
@Reinmar
Copy link
Member

Reinmar commented Dec 14, 2020

Works fine, but you need to stub console.warn() so it does not bleed to the console:


.............................................
WARN: 'Detected `console.warn()`:', 'toolbarview-line-break-ignored-when-grouping-items', ['foo', '-', 'bar'], '
Read more: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/support/error-codes.html#error-toolbarview-line-break-ignored-when-grouping-items'
Chrome 87.0.4280.88 (Linux x86_64) ToolbarView fillFromConfig() does not render line separator when the button grouping option is enabled FAILED
	Error: Detected `console.warn()`:
	    at console.<computed> [as warn] (webpack:///./build/.automated-tests/entry-point.js?:67:11)
	    at logWarning (webpack:///./packages/ckeditor5-utils/src/ckeditorerror.js?:153:10)
	    at eval (webpack:///./packages/ckeditor5-ui/src/toolbar/toolbarview.js?:21:3703)
	    at Array.map (<anonymous>)
	    at ToolbarView.fillFromConfig (webpack:///./packages/ckeditor5-ui/src/toolbar/toolbarview.js?:21:3214)
	    at Context.eval (webpack:///./packages/ckeditor5-ui/tests/toolbar/toolbarview.js?:502:9)

@Reinmar Reinmar self-requested a review December 14, 2020 14:37
@Reinmar Reinmar self-assigned this Dec 14, 2020
@Reinmar Reinmar merged commit c5e54ce into master Dec 15, 2020
@Reinmar Reinmar deleted the i/8582 branch December 15, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants