Fix for pasting plain text inside of a link breaking a link #8272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into a link and won't break the link itself.
…l link handler. Internal (clipboard): Set `event.asPlainText` flag of inputTransformation event in case plain text is detected in Clipboard plugin. This second handling should actually be moved to the PastePlainText plugin.
|
@ckeditor/qa-team can I ask you to test the thing? Some hints regarding things to test:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@ckeditor/qa-team could you test it one more time? The logic for this PR was once more time rewritten. |
|
I just noticed that some tests in the table package started failing. I'm checking it. |
It's fixed now. |
|
Things look good 👍 The previous issues have been fixed and I haven't found anything new. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (clipboard): Pasting plain text inside of a link or restricted editing editable region will no longer break them. Closes #8158.
Tests (link): Added tests for pasting plain text over the link.
Additional information