Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7803: Created the list styles UI #7845

Merged
merged 10 commits into from
Aug 18, 2020
Merged

#7803: Created the list styles UI #7845

merged 10 commits into from
Aug 18, 2020

Conversation

oleq
Copy link
Member

@oleq oleq commented Aug 14, 2020

Suggested merge commit message (convention)

Internal (list): Created the list styles UI. Closes #7803.

Feature (theme-lark): Creates styles for the ListStylesUI plugin (see #7803).

BREAKING CHANGE (ui): It is now possible to override existing components when adding new ones to the component factory (previously an error was thrown) (see #7803).


Additional information

@oleq oleq marked this pull request as ready for review August 14, 2020 14:33
@pomek pomek self-assigned this Aug 17, 2020
@pomek pomek force-pushed the i/7803-list-styles-ui branch from 79256ac to b8eeaeb Compare August 17, 2020 11:21
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

packages/ckeditor5-list/tests/liststylesui.js Outdated Show resolved Hide resolved
@pomek pomek merged commit 87beb07 into i/7801 Aug 18, 2020
@pomek pomek deleted the i/7803-list-styles-ui branch August 18, 2020 05:20
@pomek
Copy link
Member

pomek commented Aug 18, 2020

I merged it as internal without additional notes since we're not merging it into the master branch and those "commits" will be lost. I'll copy the entries to the "main" PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants