Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7453: Pasting table into table with headings should not break table layout. #7595

Merged
merged 5 commits into from
Jul 13, 2020

Conversation

niegowski
Copy link
Contributor

Suggested merge commit message (convention)

Fix (table): Pasting a table into a table with headings should not break table layout. Closes #7453.


Additional information

@niegowski niegowski requested a review from jodator July 9, 2020 13:16
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor code style issue and potential function re-use.

Other than that looks solved 👍 .

packages/ckeditor5-table/src/tableclipboard.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/src/tableclipboard.js Outdated Show resolved Hide resolved
@niegowski niegowski requested a review from jodator July 10, 2020 14:40
@jodator jodator merged commit df4485f into master Jul 13, 2020
@jodator jodator deleted the i/7453 branch July 13, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pasting table over table when selection covers heading and body sections breaks layout
2 participants