Enabled block autoformat in non-empty blocks #7576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While doing this, also ensured that the given command is not active already - so it doesn't toggle the applied style.
… block quote for a non-empty blocks.
… are no longer supported as a list autoformat trigger.
|
@ckeditor/qa-team I'd like to ask you for some manual testing 🙏 |
|
Works really smooth, I checked it also with Track Changes and real-time editing, seems to be ok 👍 |
tomalec
suggested changes
Jul 9, 2020
Co-authored-by: Tomek Wytrębowicz <[email protected]>
…phs alone. This should be reflected in manual test description.
Reinmar
reviewed
Jul 16, 2020
Reinmar
reviewed
Jul 17, 2020
Reinmar
reviewed
Jul 17, 2020
|
Implementation changed a little since the last time, @ckeditor/qa-team can I ask you for some manual testing to be sure? |
|
Looks good 👍 |
|
The code looks good and resolves the issue so after adding a test you can merge this. |
|
Ok, added a missing TC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature (autoformat): Block autoformat can also be triggered in blocks other than paragraphs. Closes #6170.
Feature (autoformat): Enabled autoformat also for blocks that are not empty.
Additional information