6574: Use TableEditing in tests. #7410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niegowski
reviewed
Jun 9, 2020
| } ); | ||
|
|
||
| describe( 'downcastInsertRow()', () => { | ||
| // The insert row downcast conversion is not executed in data pipeline. |
There was a problem hiding this comment.
Maybe we should add test to make sure that row conversion is not used in data pipeline?
There was a problem hiding this comment.
I'm not able to think of such test :) It would be very synthetic. The data pipeline conversion runs on whole, static content it do not convert "dynamic" actions (adding/removing stuff, changing attributes, etc).
jodator
commented
Jun 10, 2020
| root = doc.getRoot( 'main' ); | ||
| view = editor.editing.view; | ||
|
|
||
| markerConversion( editor.conversion, 'marker' ); |
There was a problem hiding this comment.
No expclicit test for classes as an array. /cc @niegowski
|
@niegowski the tests from #7391 were also fixed. |
niegowski
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other (table): Use real schema and conversion definitions in table tests. Closes #6574.
Other (table): Removed
options.asWidgetfrom most of the table converters which are never run in data pipeline.Additional information
This PR make a total cleanup for table tests:
downcastInsertTable()is tested for data pipeline (the data pipeline is static conversion - no need to tests changing heading rows or inserting table cells there)asWidgetoption make no sense in most of the converters.