-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced docs guide for emoji feature #17713
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psmyrek
commented
Jan 3, 2025
packages/ckeditor5-special-characters/docs/features/special-characters.md
Show resolved
Hide resolved
Added additional `.ck` class to tone search wrapper to prevent overriding its styles with the reset stylesheet.
Fixed invalid calls to the `t()` method.
…he docs, where it tries to load emoji database from.
…ntions or merge fields features.
przemyslaw-zan
requested changes
Jan 9, 2025
Co-authored-by: przemyslaw-zan <[email protected]>
Co-authored-by: przemyslaw-zan <[email protected]>
Co-authored-by: przemyslaw-zan <[email protected]>
przemyslaw-zan
approved these changes
Jan 9, 2025
pomek
reviewed
Jan 10, 2025
pomek
reviewed
Jan 10, 2025
pomek
reviewed
Jan 10, 2025
packages/ckeditor5-emoji/docs/_snippets/features/emoji-source.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Kamil Piechaczek <[email protected]>
Co-authored-by: Kamil Piechaczek <[email protected]>
pomek
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. For the final review, we will ask Bartek before merging the feature branch to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Docs: Introduced docs guide for emoji feature. Closes #17380.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.