Not displaying unsupported emoji in the emoji picker and mention plugin. #17698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martnpaneq
force-pushed
the
ck/17666-hide-unsupported-emoji
branch
from
5f03ccc to
de14e29
Compare
|
This solution bases on the solution used in emoji-picker-element. |
|
Testing this would be hard, because we would have to mock an unsupported emoji. I'm not adding any tests for now - if anyone thinks I should add them, let me know. |
martnpaneq
force-pushed
the
ck/17666-hide-unsupported-emoji
branch
2 times, most recently
from
4e308f6 to
9149e61
Compare
martnpaneq
force-pushed
the
ck/17666-hide-unsupported-emoji
branch
from
9149e61 to
e817e87
Compare
psmyrek
reviewed
Dec 31, 2024
psmyrek
reviewed
Dec 31, 2024
psmyrek
approved these changes
Dec 31, 2024
pomek
requested changes
Dec 31, 2024
pomek
reviewed
Dec 31, 2024
Conclusions added to the spike: #17666 (comment) |
pomek
reviewed
Jan 9, 2025
| @@ -140,6 +140,7 @@ const persistToWorkspace = fileName => ( { | |||
| machine: true, | |||
| steps: [ | |||
| ...bootstrapCommands(), | |||
| 'install_newest_emoji', | |||
There was a problem hiding this comment.
I am afraid the same change will be needed in the Commercial repository.
There was a problem hiding this comment.
But we can cover it in a follow-up issue.
pomek
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Not displaying unsupported emoji in the emoji picker and mention plugin. Closes #17666.
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.