Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added boilerplate for emoji plugin #17384

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Added boilerplate for emoji plugin #17384

merged 7 commits into from
Nov 6, 2024

Conversation

przemyslaw-zan
Copy link
Member

Suggested merge commit message (convention)

Internal: Added boilerplate for emoji plugin. Closes #17376.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@pomek
Copy link
Member

pomek commented Nov 4, 2024

Please make CI green. Even with an empty package, it's possible.

packages/ckeditor5-emoji/package.json Outdated Show resolved Hide resolved
packages/ckeditor5-emoji/src/index.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/ckeditor5-emoji/CONTRIBUTING.md Outdated Show resolved Hide resolved
packages/ckeditor5-emoji/README.md Outdated Show resolved Hide resolved
packages/ckeditor5-emoji/ckeditor5-metadata.json Outdated Show resolved Hide resolved
@pomek pomek requested a review from psmyrek November 6, 2024 08:11
Copy link
Contributor

@psmyrek psmyrek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@przemyslaw-zan przemyslaw-zan merged commit 31c237e into epic/ck/17361 Nov 6, 2024
8 checks passed
@przemyslaw-zan przemyslaw-zan deleted the ck/17361 branch November 6, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants