Fixed downcast conversion of restricted editing marker.

[niegowski]

Suggested merge commit message (convention)

Fix (restricted-editing): Fixed removing an inline image inside an editable region. Closes #16218.

---

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

Summary by CodeRabbit

• New Features
  • Enhanced marker handling in restricted editing mode, including a new event handler and custom converter for improved text formatting.
• Tests
  • Expanded testing suite with new cases for inline image handling and marker conversion integrity.

[coderabbitai]

Walkthrough

The recent updates focus on enhancing marker handling within CKEditor's restricted editing mode. New features like a custom converter function and event handler have been introduced to improve downcast conversion, especially for inline images and text markers. These changes aim to provide more effective management of markers by encapsulating them within specific HTML elements without disrupting the content structure.

Changes

File Path	Change Summary
packages/ckeditor5-restricted-editing/src/restrictededitingmodeediting.ts	Added a new event handler for DowncastAddMarkerEvent to handle marker conversion. Introduced custom converters for wrapping marker ranges with <span>. Adjusted existing converters for enhanced marker handling in downcast conversion.
packages/ckeditor5-restricted-editing/tests/restrictededitingmodeediting.js	Added ImageInlineEditing to plugins in the beforeEach block. Introduced new tests for handling inline images without splitting span between text nodes. Implemented a custom converter function within a nested describe block for marker conversion. Included a test to ensure proper conversion behavior when markers are consumed by another converter.

Possibly related issues

• Issue Inline objects/widgets should be wrapped by a single span by markerToHighlight downcast helpers #16287
  • The changes in this PR address the concern of wrapping inline objects/widgets with a single span element for visual consistency, especially with inline images.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 319cb12 and 4cd22f5.

Files selected for processing (2)

• packages/ckeditor5-restricted-editing/src/restrictededitingmodeediting.ts (3 hunks)
• packages/ckeditor5-restricted-editing/tests/restrictededitingmodeediting.js (2 hunks)

Files skipped from review as they are similar to previous changes (2)

• packages/ckeditor5-restricted-editing/src/restrictededitingmodeediting.ts
• packages/ckeditor5-restricted-editing/tests/restrictededitingmodeediting.js

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.