Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a 'translations' object in the configuration #15792

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

illia-stv
Copy link
Contributor

@illia-stv illia-stv commented Feb 2, 2024

Suggested merge commit message (convention)

Feature (core,utils): Should use translations that are passed in the config. Closes #15713.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@illia-stv illia-stv self-assigned this Feb 2, 2024
@illia-stv illia-stv added the squad:core Issue to be handled by the Core team. label Feb 2, 2024
@illia-stv
Copy link
Contributor Author

illia-stv commented Feb 2, 2024

Due reverts in history in PR we decided created new PR to avoid "GIT" undesired problems.

packages/ckeditor5-core/src/editor/editor.ts Outdated Show resolved Hide resolved
packages/ckeditor5-utils/src/translation-service.ts Outdated Show resolved Hide resolved
packages/ckeditor5-utils/src/locale.ts Outdated Show resolved Hide resolved
@illia-stv illia-stv requested a review from niegowski February 2, 2024 14:18
@niegowski
Copy link
Contributor

@illia-stv Please make the merge commit message more understandable from the user/integrator point of view.

@illia-stv illia-stv merged commit 8561da7 into master Feb 5, 2024
6 checks passed
@illia-stv illia-stv deleted the ck/15713-allow-passing-a-transation-object branch February 5, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:core Issue to be handled by the Core team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New installation methods] Allow passing a translations object in the configuration
4 participants