Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing ckeditor5-metadata.json file for undo and improved me… #15440

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Added missing ckeditor5-metadata.json file for undo and improved me… #15440

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ccbca9b
Added missing `ckeditor5-metadata.json` file for undo and improved me…
martnpaneq Dec 1, 2023
8fb1cf9
Fixed docs path in undo metadata.
martnpaneq Dec 1, 2023
364e840
Addressed PR comments.
martnpaneq Dec 4, 2023
c1175d6
Added missing `iconPath` for `imageTextAlternative` - inline and bloc…
martnpaneq Dec 5, 2023
2860d24
Removed `undo` and `redo` `uiComponents` from Essentials metadata.
martnpaneq Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions packages/ckeditor5-undo/ckeditor5-metadata.json
View file
Open in desktop
martnpaneq marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
{
"plugins": [
{
"name": "Undo",
"className": "Undo",
"description": "Inserts buttons with undo and redo functionality.",
martnpaneq marked this conversation as resolved.
Show resolved Hide resolved
"docs": "features/undo-redo.html",
"path": "src/undo.js",
"uiComponents": [
martnpaneq marked this conversation as resolved.
Show resolved Hide resolved
{
"type": "Button",
"name": "undo",
"iconPath": "theme/icons/undo.svg"
},
{
"type": "Button",
"name": "redo",
"iconPath": "theme/icons/redo.svg"
}
]
}
]
}
10 changes: 7 additions & 3 deletions scripts/ci/validate-metadata-files.js
View file
Open in desktop
martnpaneq marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,13 @@ function getMissingExports( packageData ) {
function getMissingIcons( packageData, options ) {
return packageData.metadata.plugins
.filter( plugin => plugin.uiComponents )
.flatMap( plugin => plugin.uiComponents.map( uiComponent => uiComponent.iconPath ) )
.filter( Boolean )
.map( iconPath => {
.flatMap( plugin => plugin.uiComponents.map( uiComponent => ( { ...plugin, iconPath: uiComponent.iconPath } ) ) )
.filter( ( { iconPath } ) => iconPath !== undefined )
.map( ( { iconPath, name } ) => {
if ( iconPath === '' ) {
return `${ name } has an empty iconPath. Either define or remove it.`;
}

if ( iconPath.startsWith( '@ckeditor/' ) ) {
return iconPath;
}
Expand Down