Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the missing type for the list view. #15434

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Add the missing type for the list view. #15434

merged 6 commits into from
Dec 5, 2023

Conversation

gorzelinski
Copy link
Contributor

Suggested merge commit message (convention)

Add the missing type for the list view. Closes #15298.

Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

mmotyczynska
mmotyczynska requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@mmotyczynska mmotyczynska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd introduce small improvements to your solution, check the comments please 🙂

packages/ckeditor5-ui/src/list/listitemgroupview.ts Outdated Show resolved Hide resolved
packages/ckeditor5-ui/src/list/listview.ts Outdated Show resolved Hide resolved
mmotyczynska
mmotyczynska approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@mmotyczynska mmotyczynska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gorzelinski gorzelinski requested a review from illia-stv December 5, 2023 10:51
@gorzelinski gorzelinski merged commit 9ea94d4 into master Dec 5, 2023
@gorzelinski gorzelinski deleted the ck/15298 branch December 5, 2023 12:21
oleq added a commit that referenced this pull request Dec 7, 2023
@oleq
WIP: 9ea94d4 Merge pull request #15434 from ckeditor/ck/15298
8b9e0d0
@mmotyczynska mmotyczynska mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmotyczynska mmotyczynska mmotyczynska approved these changes

@illia-stv illia-stv illia-stv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing ListSeparatorView type in ListView view collection
3 participants
@gorzelinski @illia-stv @mmotyczynska