Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block elements should not be indented in Document Lists. #14759

Merged

Conversation

mmotyczynska
Copy link
Contributor

@mmotyczynska mmotyczynska commented Aug 6, 2023

Suggested merge commit message (convention)

Fix (indent): Block elements should not be indented in Document Lists. Closes #14155.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@mmotyczynska mmotyczynska changed the title blockIndent command should be disabled for block elements in document… Block elements should not be indented in Document Lists Aug 6, 2023
@mmotyczynska mmotyczynska changed the title Block elements should not be indented in Document Lists Block elements should not be indented in Document Lists. Aug 6, 2023
@mmotyczynska mmotyczynska requested a review from niegowski August 18, 2023 12:55
Copy link
Contributor

@niegowski niegowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for indent block command.

packages/ckeditor5-indent/src/indentblockcommand.ts Outdated Show resolved Hide resolved
packages/ckeditor5-indent/src/indentblockcommand.ts Outdated Show resolved Hide resolved
@mmotyczynska mmotyczynska requested a review from niegowski August 25, 2023 10:58
@niegowski niegowski merged commit fec3d4b into master Aug 29, 2023
@niegowski niegowski deleted the ck/14155-list-markers-should-stick-to-list-items-when-indented branch August 29, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List markers should "stick" to list items when a list is indented
2 participants