Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use global not as variable name to fix problem with Jest #12972

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

alexander-schranz
Copy link
Contributor

Suggested merge commit message (convention)

Type: Message. Closes #12971.


Additional information

Currenlty jest tests failing when upgrading ckeditor from 34 to 35.

@alexander-schranz
Copy link
Contributor Author

The failing CI looks unrelated at seem also fail on the main branch.

@arkflpc arkflpc merged commit 05e80c0 into ckeditor:master Dec 29, 2022
@alexander-schranz alexander-schranz deleted the patch-1 branch December 29, 2022 11:10
@alexander-schranz
Copy link
Contributor Author

@arkflpc Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CKEditor 34 -> 35: SyntaxError: Identifier 'global' has already been declared
2 participants