Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't delete a list after widget element using backspace #8706

Closed
neongreen opened this issue Dec 17, 2020 · 1 comment · Fixed by #8569
Closed

Can't delete a list after widget element using backspace #8706

neongreen opened this issue Dec 17, 2020 · 1 comment · Fixed by #8569
Assignees
@niegowski
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:list package:widget squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 39 (v25...

Comments

@neongreen
Copy link

📝 Provide detailed reproduction steps (if any)

  1. Go to https://ckeditor.com/ckeditor-5/demo/
  2. Paste an image
  3. Below the image, create a checkbox with any text
  4. Go to the beginning of the checkbox text and press Backspace

2020-12-17 14 06 30

✔️ Expected result

The checkbox becomes a normal paragraph.

❌ Actual result

Nothing is deleted, and the image is selected.

Note that everything works as expected without an image.

📃 Other details

  • Browser: Chrome
  • OS: macOS Catalina

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@neongreen neongreen added the type:bug This issue reports a buggy (incorrect) behavior. label Dec 17, 2020
@LukaszGudel
Copy link
Contributor

Hi, thank you for the report. I can confirm this issue. 

This issue can be found when any type of a list is added after widget element (image, embeded media, table).

@LukaszGudel LukaszGudel changed the title Can't delete a checkbox if there is an image before it Can't delete a list after widget element Dec 21, 2020
@Mgsy Mgsy added this to the backlog milestone Dec 21, 2020
@LukaszGudel LukaszGudel added domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. labels Dec 21, 2020
@LukaszGudel LukaszGudel changed the title Can't delete a list after widget element Can't delete a list after widget element using backspace Dec 21, 2020
@niegowski niegowski mentioned this issue Dec 21, 2020
Merged
@niegowski niegowski self-assigned this Dec 21, 2020
@niegowski niegowski modified the milestones: backlog, iteration 39 Dec 21, 2020
Reinmar added a commit that referenced this issue Dec 22, 2020
@Reinmar
Merge pull request #8569 from ckeditor/i/8137
2d9954c 
Feature (typing): Empty block element at the beginning of the limit element should be converted to a paragraph on backspace key press. Closes #8137.

Feature (block-quote): Block-quote should be split on backspace key press at the beginning of the block-quote. Closes #7636.

Fix (list): The `delete` event handler listening on a higher priority to avoid intercepting by the block-quote and widget handler. Closes #8706.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:list package:widget squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 39 (v25.0.0)
5 participants
@oleq @niegowski @neongreen @Mgsy @LukaszGudel