Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown button's arrow is misaligned #831

Closed
Reinmar opened this issue Feb 8, 2018 · 2 comments
Closed

Dropdown button's arrow is misaligned #831

Reinmar opened this issue Feb 8, 2018 · 2 comments
Assignees
@jodator @oleq
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 14

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 8, 2018

image

Perhaps related to ckeditor/ckeditor5-ui#361.

cc @jodator @oleq
@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed labels Feb 8, 2018
@Reinmar Reinmar added this to the iteration 14 milestone Feb 8, 2018
@Reinmar Reinmar mentioned this issue Feb 8, 2018
Merged
@oleq
Copy link
Member

oleq commented Feb 8, 2018

It's because before the refac it was 10x10px and now it is 10x20px. Something went wrong with styles.

@oleq
Copy link
Member

oleq commented Feb 8, 2018 •
edited
Loading

In fact, there are 2 misalignments:
image

The one in the alignment can be fixed by removing the following https://github.com/ckeditor/ckeditor5-ui/blob/master/theme/components/dropdown/dropdown.css#L17-L18

The one in the headings dropdown is because there's an unnecessary right margin, a default for button icons. But since the arrow is not a regular icon, it has a different (absolute) position and it does not need the right margin.

Both dropdown arrows should have the same styles. ATM they have different margins for some reason. We need to fix that.

@jodator jodator self-assigned this Feb 8, 2018
@jodator jodator mentioned this issue Feb 8, 2018
Merged
oleq added a commit to ckeditor/ckeditor5-ui that referenced this issue Feb 9, 2018
@oleq
Merge pull request #367 from ckeditor/t/ckeditor5/831
507549f 
Fix: Button icon styles should not touch the dropdown's arrow. Closes ckeditor/ckeditor5#831.
oleq added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Feb 9, 2018
@oleq
Internal: Button icon styles should not touch dropdown's arrow (see c…
d861552 
…keditor/ckeditor5#831).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

@oleq oleq

Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 14
Development

No branches or pull requests
3 participants
@Reinmar @jodator @oleq