Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the "Theme customization" (a.k.a. dark mode) guide and snippets to the new look of inputs #8275

Closed
oleq opened this issue Oct 16, 2020 · 1 comment · Fixed by #8541
Closed

Update the "Theme customization" (a.k.a. dark mode) guide and snippets to the new look of inputs #8275

oleq opened this issue Oct 16, 2020 · 1 comment · Fixed by #8541
Assignees
@niegowski
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:theme-lark squad:core Issue to be handled by the Core team. type:docs This issue reports a task related to documentation (e.g. an idea for a guide). type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 38 (v24...

Comments

@oleq
Copy link
Member

oleq commented Oct 16, 2020

Provide a description of the task

Follow-up of #1098.

should be more like
@oleq oleq added type:task This issue reports a chore (non-production change) and other types of "todos". type:docs This issue reports a task related to documentation (e.g. an idea for a guide). package:theme-lark domain:ui/ux This issue reports a problem related to UI or UX. squad:core Issue to be handled by the Core team. labels Oct 16, 2020
@oleq oleq mentioned this issue Nov 4, 2020
Merged
@oleq oleq added this to the iteration 38 milestone Nov 5, 2020
@oleq
Copy link
Member Author

oleq commented Nov 25, 2020

Things to do here in the guide and the manual test:

  • A new custom property --ck-color-labeled-field-label-background in labeledfieldview.css in theme-lark (could also be in _colors.css). 
  • --ck-color-labeled-field-label-background: var(--ck-custom-background)
  • --ck-color-input-background: var(--ck-custom-background)
  • --ck-color-input-disabled-text should be brightened to increase the contrast to something like hsl(0deg 0% 78%)

@niegowski niegowski self-assigned this Nov 26, 2020
@niegowski niegowski mentioned this issue Nov 27, 2020
Merged
oleq added a commit that referenced this issue Nov 30, 2020
@oleq
Merge pull request #8541 from ckeditor/i/8275
cd70b55 
Internal (theme-lark): Inverted theme should properly display labeled fields. Closes #8275.
@adamerose adamerose mentioned this issue Jun 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:theme-lark squad:core Issue to be handled by the Core team. type:docs This issue reports a task related to documentation (e.g. an idea for a guide). type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 38 (v24.0.0)
Development

Successfully merging a pull request may close this issue.

Updated inverted theme. ckeditor/ckeditor5
2 participants
@oleq @niegowski