Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve InputObserver so the event passes and normalizes additional information #7996

Closed
oleq opened this issue Sep 2, 2020 · 1 comment
Closed

Improve InputObserver so the event passes and normalizes additional information #7996

oleq opened this issue Sep 2, 2020 · 1 comment
Assignees
@oleq
Labels
domain:dx This issue reports a developer experience problem or possible improvement. package:typing type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 36 (v23...

Comments

@oleq
Copy link
Member

oleq commented Sep 2, 2020

Provide a description of the task

ATM the observer does nothing special; It passes the event through. The beforeInput event comes with some interesting properties, though:

  • type,
  • getTargetRanges(),
  • data,
  • dataTransfer,
  • isComposing

TODO:

  • maybe we could have some is() interface for the type, for instance is( 'insertText' )?
  • data and dataTransfer should be normalized because depending on OS/browser/type they complement each other (it's a mess...)
  • ranges should be extracted using getTargetRanges()
@oleq oleq added type:task This issue reports a chore (non-production change) and other types of "todos". domain:dx This issue reports a developer experience problem or possible improvement. domain:ui/ux This issue reports a problem related to UI or UX. package:typing and removed domain:ui/ux This issue reports a problem related to UI or UX. labels Sep 2, 2020
@Reinmar Reinmar mentioned this issue Sep 3, 2020
Closed
13 tasks
@oleq oleq added this to the iteration 36 milestone Sep 3, 2020
@oleq oleq added the squad:dx label Sep 3, 2020
@oleq oleq self-assigned this Sep 3, 2020
@oleq oleq mentioned this issue Sep 8, 2020
Merged
niegowski added a commit that referenced this issue Sep 10, 2020
@niegowski
Merge pull request #8043 from ckeditor/i/7996-better-input-observer
afb3736 
Feature (engine): Improved `InputObserver` with useful input event data properties. Closes #7996.

Other (clipboard): Moved the `DataTransfer` helper class to ckeditor5-engine (see #7996).

Internal (image): Updated import paths and docs since the `DataTransfer` helper class has been moved to [ckeditor5-engine](https://www.npmjs.com/package/@ckeditor/ckeditor5-engine) (see #7996).

MINOR BREAKING CHANGE (clipboard): The `DataTransfer` helper class has been moved to [ckeditor5-engine](https://www.npmjs.com/package/@ckeditor/ckeditor5-engine). Please update the import path in your integrations to `'@ckeditor/ckeditor5-engine/src/view/datatransfer'` (see #7996).
@oleq
Copy link
Member Author

oleq commented Sep 10, 2020

Closed in #8043.

@oleq oleq closed this as completed Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
domain:dx This issue reports a developer experience problem or possible improvement. package:typing type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 36 (v23.0.0)
Development

No branches or pull requests
1 participant
@oleq