Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce method for removing row from table #6545

Closed
jodator opened this issue Apr 3, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-table#297
Closed

Introduce method for removing row from table #6545

jodator opened this issue Apr 3, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-table#297
Assignees
@jodator
Labels
package:table type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 31 (v19...

Comments

@jodator
Copy link
Contributor

jodator commented Apr 3, 2020

📝 Provide a description of the new feature

Modifying Table structure is a complex task because of many functional requirements. Not every one knows them all and one can forget about why some things must happen in tables. This is especially painful when dealing with colspan or rowspan attributes of table cells and which implication are not obvious.

A single method (not a helper) that is available to all devs is needed though.

I'd like to move the logic of removing single row to TableUtils as removeRow command.

If you'd like to see this feature implemented, add a 👍 reaction to this post.
@jodator jodator added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:table labels Apr 3, 2020
@jodator jodator self-assigned this Apr 3, 2020
@jodator jodator mentioned this issue Apr 3, 2020
Closed
@jodator jodator changed the title Introduce method for removing row froma a table cell. Introduce method for removing row from a table Apr 3, 2020
@jodator jodator changed the title Introduce method for removing row from a table Introduce method for removing row from table Apr 3, 2020
This was referenced Apr 3, 2020
Closed
Merged
@Mgsy Mgsy added this to the iteration 31 milestone Apr 6, 2020
@jodator jodator mentioned this issue Apr 7, 2020
Closed
oleq added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 7, 2020
@oleq
Merge pull request #297 from ckeditor/i/6545
c6770ba 
Feature: Introduce the `TableUtils.removeRows()` method. Closes ckeditor/ckeditor5#6545.
mlewand pushed a commit that referenced this issue May 1, 2020
@oleq
Merge pull request #297 from ckeditor/i/6545
233a0e2 
Feature: Introduce the `TableUtils.removeRows()` method. Closes #6545.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:table type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

I/6545: Introduce TableUtils.removeRows() utility method. ckeditor/ckeditor5-table
2 participants
@jodator @Mgsy