Disabling table selection should collapse selection

[scofalik]

📝 Provide a description of the improvement

At this moment, when you disable table selection plugin, the selection stays as it was, that is, it can be done on multiple cells. This is in my opinion wrong - if I disable the multi-cell selection I don't want it to be existing in the editor anymore.

---

If you'd like to see this improvement implemented, add a 👍 reaction to this post.

[scofalik]

Unfortunately, when I do this:

tableSelectionPlugin.forceDisabled( 'trackChanges' );

editor.model.change( writer => {
	const range = editor.model.schema.getNearestSelectionRange( editor.model.document.selection.getFirstPosition() );

	writer.setSelection( range );
} );

The range is still collapsed on a cell, instead of inside :|.

[mlewand]

Yea, I guess you need to do some extra magic to shrink to inside of a first/last table cell, as the selection is always outside of a cell.

[scofalik]

I've used this and it seems to work:

editor.model.change( writer => {
	let position = editor.model.document.selection.getFirstPosition();

	if ( position.nodeAfter && position.nodeAfter.is( 'tableCell' ) ) {
		position = writer.createPositionAt( position.nodeAfter, 0 );
	}

	const range = editor.model.schema.getNearestSelectionRange( position );

	writer.setSelection( range );
} );

But I treat it as a hack and looking foward to having it inside the plugin.

[scofalik]

It seems to work even for more difficult cases like this:

(selection ends up on an image) or an empty cell.

[mlewand]

We were able to make a temp workaorund in CF, since we need to start testing iteration 30 ASAP I'm moving this to it. 31st