Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge cell left/right options are never enabled #6368

Closed
Reinmar opened this issue Mar 2, 2020 · 5 comments · Fixed by ckeditor/ckeditor5-table#271
Closed

Merge cell left/right options are never enabled #6368

Reinmar opened this issue Mar 2, 2020 · 5 comments · Fixed by ckeditor/ckeditor5-table#271
Assignees
@oleq
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 30 (v18...

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 2, 2020

📝 Provide detailed reproduction steps (if any)

On: https://ckeditor.com/docs/ckeditor5/latest/features/table.html#table-and-cell-styling-tools

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Reinmar Reinmar added the type:bug This issue reports a buggy (incorrect) behavior. label Mar 2, 2020
@Reinmar
Copy link
Member Author

Reinmar commented Mar 2, 2020

cc @ckeditor/qa-team is it a regression? If so, could you bisect this?

@Reinmar Reinmar added this to the iteration 30 milestone Mar 2, 2020
@Mgsy
Copy link
Member

Mgsy commented Mar 3, 2020

This bug has been introduced in v16. It occurs only if a table contains a header. I'll bisect it.

@Mgsy
Copy link
Member

Mgsy commented Mar 3, 2020

It occurs since this change - ckeditor/ckeditor5-table@c9c6954.

@Reinmar Reinmar mentioned this issue Mar 4, 2020
Merged
@scofalik
Copy link
Contributor

scofalik commented Mar 4, 2020

If you will change something in merging behavior, please add a ticket to test those changes in CF.

@jswiderski
Copy link

From what I have checked problem only occurs when Header Column is applied (Header Row looks fine).

@oleq oleq mentioned this issue Mar 11, 2020
Merged
mlewand added a commit to ckeditor/ckeditor5-table that referenced this issue Mar 11, 2020
@mlewand
Merge pull request #271 from ckeditor/i/6368
c088814 
Fix: Merge left and right commands should be always enabled if the execution does not cross the heading column boundary. Closes ckeditor/ckeditor5#6368.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 30 (v18.0.0)
6 participants
@Reinmar @oleq @scofalik @jswiderski @mlewand @Mgsy