Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add direction to model.deleteContent() #6355

Closed
Reinmar opened this issue Feb 28, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-typing#225
Closed

Add direction to model.deleteContent() #6355

Reinmar opened this issue Feb 28, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-typing#225
Assignees
@oleq
Labels
package:table type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 30 (v18...

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 28, 2020 •
edited
Loading

📝 Provide a description of the improvement

Required by #6328 and #3115.

In this ticket, let's add the property and pass it from the DeleteCommand#execute() (which already gets the direction).

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@Reinmar Reinmar added type:improvement This issue reports a possible enhancement of an existing feature. package:table status:confirmed labels Feb 28, 2020
@Reinmar Reinmar added this to the iteration 30 milestone Feb 28, 2020
@Reinmar Reinmar mentioned this issue Feb 28, 2020
Closed
This was referenced Mar 3, 2020
Merged
Merged
Reinmar added a commit to ckeditor/ckeditor5-engine that referenced this issue Mar 4, 2020
@Reinmar
Merge pull request #1827 from ckeditor/i/6356
3564ce5 
Docs: Extended `Model#deleteContent()` docs with an information about the direction option (see ckeditor/ckeditor5#6356, ckeditor/ckeditor5#6355).
Reinmar added a commit to ckeditor/ckeditor5-typing that referenced this issue Mar 4, 2020
@Reinmar
Merge pull request #225 from ckeditor/i/6356
cb75e45 
Other: `DeleteCommand` should pass its direction to `Model#deleteContent()`. Closes ckeditor/ckeditor5#6355. See ckeditor/ckeditor5#6356.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:table type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 30 (v18.0.0)
2 participants
@Reinmar @oleq