Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ckeditor5-image doesn't have 100% CC due to missing imageloadobserver test case #6326

Closed
Reinmar opened this issue Feb 25, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-image#344
Closed

ckeditor5-image doesn't have 100% CC due to missing imageloadobserver test case #6326

Reinmar opened this issue Feb 25, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-image#344
Assignees
@mlewand
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 30 (v18...

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 25, 2020

Provide a description of the task

Write missing tests.
@Reinmar Reinmar added the type:task This issue reports a chore (non-production change) and other types of "todos". label Feb 25, 2020
@Reinmar Reinmar added this to the iteration 30 milestone Feb 25, 2020
@Reinmar Reinmar mentioned this issue Feb 25, 2020
Merged
@mlewand
Copy link
Contributor

mlewand commented Feb 27, 2020

I guess you're referring to missing image observer unit test, which is not really related to widget resize - I'll update the summary.

@mlewand mlewand changed the title ckeditor5-widget doesn't have 100% CC due to widget resize ckeditor5-image doesn't have 100% CC due to missing imageloadobserver test case Feb 27, 2020
@mlewand mlewand mentioned this issue Feb 27, 2020
Merged
Reinmar added a commit to ckeditor/ckeditor5-image that referenced this issue Feb 27, 2020
@Reinmar
Merge pull request #344 from ckeditor/i/6326
12445d7 
Tests: Added a missing test case for image load observer. Closes ckeditor/ckeditor5#6326.
@mlewand mlewand mentioned this issue Mar 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlewand mlewand

Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 30 (v18.0.0)
Development

Successfully merging a pull request may close this issue.

Added a missing test case for image load observer ckeditor/ckeditor5-image
2 participants
@Reinmar @mlewand