Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text with attribute in an exception marker is missing cursor: text #6272

Closed
Mgsy opened this issue Feb 14, 2020 · 3 comments · Fixed by ckeditor/ckeditor5-theme-lark#267
Closed

Text with attribute in an exception marker is missing cursor: text #6272

Mgsy opened this issue Feb 14, 2020 · 3 comments · Fixed by ckeditor/ckeditor5-theme-lark#267
Assignees
@panr
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 30 (v18...

Comments

@Mgsy
Copy link
Member

Mgsy commented Feb 14, 2020

📝 Provide detailed reproduction steps (if any)

  1. Put the caret in an exception marker.
  2. Insert some styled text, i.e. with bold.
  3. Hover it.

✔️ Expected result

The cursor displays as text.

❌ Actual result

The cursor displays as default.

📃 Other details

GIF
bug_cke5

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Mgsy Mgsy added the type:bug This issue reports a buggy (incorrect) behavior. label Feb 14, 2020
@Reinmar
Copy link
Member

Reinmar commented Feb 14, 2020

cc @panr

@Mgsy Mgsy added this to the backlog milestone Feb 18, 2020
@panr
Copy link
Contributor

panr commented Feb 18, 2020

Probably bold has some other styles that override our latest changes... I will take a look at this 👍

@panr panr self-assigned this Feb 18, 2020
@panr panr mentioned this issue Feb 25, 2020
Merged
@panr
Copy link
Contributor

panr commented Feb 25, 2020

PR is ready to check. I refactored code for styling as well.

Reinmar added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Feb 26, 2020
@Reinmar
Merge pull request #267 from ckeditor/i/6272
a20d13b 
Fix: Pointer inside the restricted editing exception should be set to text for all children. Closes ckeditor/ckeditor5#6272.
@Reinmar Reinmar modified the milestones: backlog, iteration 30 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@panr panr

Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 30 (v18.0.0)
Development

Successfully merging a pull request may close this issue.

i/6272: Fix styles for restricted editing cursor behaviour ckeditor/ckeditor5-theme-lark
3 participants
@Reinmar @panr @Mgsy