Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling spanned cell in pasting scenarios #6122

Closed
3 tasks
jodator opened this issue Jan 22, 2020 · 1 comment · Fixed by #7226
Closed
3 tasks

Handling spanned cell in pasting scenarios #6122

jodator opened this issue Jan 22, 2020 · 1 comment · Fixed by #7226
Assignees
Labels
package:table type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@jodator
Copy link
Contributor

jodator commented Jan 22, 2020

📝 Provide a description of the new feature

This case requires #6120 & #6121 to proceed. Add tests and fix potential issues of pasting tables with spanned cells.

A table feature already provides a table layout post-fixer that handles edge cases in which such a broken layout could be created in the editor (most often during collaboration). However, the paste must be aware of such a condition and minimize the effect of a potentially broken layout by trimming the cells that extend over the rectangle selection.

Cases to handle

  • selection has spans at the edges (might not work well or is blocked)
  • non-rectangular selection (might be tricky) - require to split table cell similarly when changing headings algorithm
  • non-rectangular pasted table

If you'd like to see this feature implemented, add a 👍 reaction to this post.

@jodator jodator added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:table labels Jan 22, 2020
@Reinmar Reinmar added this to the nice-to-have milestone Jan 27, 2020
@jodator jodator modified the milestones: nice-to-have, iteration 32 Apr 30, 2020
@jodator
Copy link
Contributor Author

jodator commented May 13, 2020

Also handle this case: #6786 (comment).

@jodator jodator self-assigned this May 15, 2020
niegowski added a commit that referenced this issue May 20, 2020
Internal (table): Handle spanned table cells in pasting scenarios. Closes #6122.

Fix (table): Setting column as header will now split col-spanned cells. Closes #6658.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants