Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It should be possible to hide/disable a widget toolbar #5964

Closed
mlewand opened this issue Dec 11, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-widget#113
Closed

It should be possible to hide/disable a widget toolbar #5964

mlewand opened this issue Dec 11, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-widget#113
Assignees
@mlewand
Labels
package:widget type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 29 (v17...

Comments

@mlewand
Copy link
Contributor

mlewand commented Dec 11, 2019 •
edited
Loading

📝 Provide a description of the new feature

Repositioning widget toolbar comes with a slight performance overhead.

This is especially was especially visible with widget resize feature, where the toolbar would be repositioned on each mousemove event. Since the balloon toolbar is not needed during the resize process it's OK to hide it for that time.

So the WidgetToolbarRepository plugin should expose a method to temporarily disable it, similar like commands do with forceDisabled().

Currently widget toolbar exposes some API for that but it's only private.

If you'd like to see this feature implemented, add a 👍 reaction to this post.
@mlewand mlewand added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). status:confirmed package:widget labels Dec 11, 2019
@mlewand mlewand added this to the iteration 29 milestone Dec 11, 2019
@mlewand mlewand mentioned this issue Dec 11, 2019
Merged
@mlewand mlewand changed the title It should be possible to disable a widget toolbar It should be possible to hide/disable a widget toolbar Dec 11, 2019
@mlewand mlewand mentioned this issue Dec 11, 2019
Merged
@mlewand mlewand self-assigned this Dec 16, 2019
@mlewand mlewand mentioned this issue Dec 16, 2019
Merged
Reinmar added a commit to ckeditor/ckeditor5-widget that referenced this issue Dec 17, 2019
@Reinmar
Merge pull request #113 from ckeditor/i/5964
b9cf062 
Feature: Introduced API to temporarily disable the `WidgetToolbarRepository` plugin (prevent the toolbar from showing up). Closes ckeditor/ckeditor5#5964.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlewand mlewand

Labels
package:widget type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 29 (v17.0.0)
Development

Successfully merging a pull request may close this issue.

Introduced disabling API for the WidgetToolbarRepository class ckeditor/ckeditor5-widget
1 participant
@mlewand