Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define package keywords #551

Closed
Reinmar opened this issue Sep 8, 2017 · 6 comments
Closed

Define package keywords #551

Reinmar opened this issue Sep 8, 2017 · 6 comments
Assignees
Labels
status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Sep 8, 2017

There are a couple of groups of packages:

  • builds
  • editor creators
  • framework
  • utils / API

It'd be good to mark each package with one or more keywords.

Right now we only marked builds, but with the ckeditor5-build keyword, which I think should be differently formatted, so we don't have ckeditor5-creator, ckeditor5-framework keywords (which might look like package names).

We need to check what kind of word separator we could use – maybe simply a space?

@Reinmar Reinmar added candidate:1.0.0 status:discussion type:improvement This issue reports a possible enhancement of an existing feature. labels Sep 8, 2017
@Reinmar Reinmar added this to the iteration 12 milestone Sep 8, 2017
@Reinmar
Copy link
Member Author

Reinmar commented Sep 14, 2017

@pomek, could you make a quick research what kind of characters work in keywords and how similar (multi-package) projects use keywords? Like webpack, Babel, gulp, d3, etc.

@pomek
Copy link
Member

pomek commented Sep 26, 2017

Webpack

No keywords in package.json.

Babel

The same like Webpack – no keywords:

Gulp

All plugins use a few words. The common one is gulpplugin:

d3

The common keyword is d3-module:

Angular.js

No common keyword:

Situation of Angular is similar to Angular.js

ESLint

Common keyword for plugins is eslint:

@Reinmar
Copy link
Member Author

Reinmar commented Sep 26, 2017

Thanks!

@Reinmar
Copy link
Member Author

Reinmar commented Sep 26, 2017

OK, so I'd propose doing this

  1. All packages should have "ckeditor5" keyword.
  2. Additionally, specific groups can be marked:
  • core libs don't need to be marked because this set is closed,
  • editors should be marked with "ckeditor5-editor",
  • features should be marked with "ckeditor5-feature",
  • themes with "ckeditor5-theme",
  • and builds are already marked with "ckeditor5-build".

WDYT?

@Reinmar
Copy link
Member Author

Reinmar commented Sep 27, 2017

OK, so with 2 👍 I'm going to introduce these keywords. However, in the meantime I thought that core libs could be marked with "ckeditor5-lib" anyway.

@Reinmar
Copy link
Member Author

Reinmar commented Sep 27, 2017

Done.

@Reinmar Reinmar closed this as completed Sep 27, 2017
@Reinmar Reinmar self-assigned this Sep 28, 2017
mlewand pushed a commit that referenced this issue May 1, 2020
Other: Removed the obsolete `DropdownView#focusTracker`. Closes #6548.

MINOR BREAKING CHANGE: The `DropdownView#focusTracker` property has been removed as it served no purpose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants