Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "balloon toolbar editor" into "balloon editor" #546

Closed
wwalc opened this issue Sep 7, 2017 · 0 comments
Closed

Rename "balloon toolbar editor" into "balloon editor" #546

wwalc opened this issue Sep 7, 2017 · 0 comments
Assignees
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone

Comments

@wwalc
Copy link
Member

wwalc commented Sep 7, 2017

I know we had a similar discussion in #402, but let me propose this anyway.

Right now we have three different types of editors:

  • Classic editor
  • Inline editor
  • Balloon toolbar editor

Even if "balloon toolbar editor" tells more precisely what kind of editor it is, IMO is worse than "balloon editor", because:

  • It's inconsistent with other names (where toolbar is not mentioned).
  • It's longer, making all sentences like "Download balloon toolbar editor build" longer than they should be.
  • "Classic"/"Inline" are not meaningful either, because one does not know what "classic" means unless he reads about it and see the demo. So the argumentation about semantic correctness is not that critical imo.
  • It's easier to look at the code samples when you see things which are very similar to each other: ClassicEditor.create(), InlineEditor.create(), BalloonEditor.create().
  • It could be also easier this way to propose via CDN something like this:
https://cdn.ckeditor.com/ckeditor5/0.11.0/classic/ckeditor.js
https://cdn.ckeditor.com/ckeditor5/0.11.0/inline/ckeditor.js
https://cdn.ckeditor.com/ckeditor5/0.11.0/balloon/ckeditor.js

I know the change will be a bit painful to process, but this is the last moment to eventually do this.

@Reinmar Reinmar self-assigned this Sep 7, 2017
@Reinmar Reinmar added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". labels Sep 7, 2017
@Reinmar Reinmar added this to the iteration 12 milestone Sep 7, 2017
Reinmar added a commit to ckeditor/ckeditor5-build-balloon that referenced this issue Sep 7, 2017
…d-balloon-toolbar` to `@ckeditor/ckeditor5-build-balloon`. See ckeditor/ckeditor5#546 for more information.

BREAKING CHANGE: The build name has been changed. See ckeditor/ckeditor5#546.
Reinmar added a commit to ckeditor/ckeditor5-editor-balloon that referenced this issue Sep 7, 2017
…ld-balloon-toolbar` to `@ckeditor/ckeditor5-build-balloon` (the class name has been changed to `BalloonEditor`). See ckeditor/ckeditor5#546 for more information.

BREAKING CHANGE: The editor name has been changed. See ckeditor/ckeditor5#546.
@Reinmar Reinmar closed this as completed in fb4a4e4 Sep 7, 2017
rivernews pushed a commit to rivernews/ckeditor5-build-balloon-2022 that referenced this issue Dec 31, 2021
…d-balloon-toolbar` to `@ckeditor/ckeditor5-build-balloon`. See ckeditor/ckeditor5#546 for more information.

BREAKING CHANGE: The build name has been changed. See ckeditor/ckeditor5#546.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

2 participants