Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a custom navigation through tables #3267

Closed
Reinmar opened this issue Apr 16, 2019 · 3 comments · Fixed by ckeditor/ckeditor5-table#304
Closed

Implement a custom navigation through tables #3267

Reinmar opened this issue Apr 16, 2019 · 3 comments · Fixed by ckeditor/ckeditor5-table#304
Assignees
Labels
package:table type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 16, 2019

Currently, we allow the browser to do its thing. Some support Tab, most support arrow keys, but all that is inconsistent and buggy. We should design and implement our own solution.

@Reinmar
Copy link
Member Author

Reinmar commented Apr 16, 2019

In fact, this is a special case of https://github.com/ckeditor/ckeditor5-widget/issues/84.

I think that the widget feature should introduce a base way to navigate to nested editables and then the table feature should override that in a way which will make sense for tables.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the nice-to-have milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:table labels Oct 9, 2019
@Reinmar
Copy link
Member Author

Reinmar commented Apr 2, 2020

Two stages:

  • Handling selection at the cell boundary. When the selection is at the start and you press up, then you go to the end of the cell above the current cell. When you press left, you go to the end of the cell on the left. Symmetrical for the end of cell positions. Note: an empty table creates an interesting case and should be handled correctly.
  • Handling selections not at the cell boundary by comparing rects.

In both cases, let's try to mimic Google Docs behavior as closely as possible, with the exception that when you move to the adjacent cell, move to the end/start of it.

@oleq
Copy link
Member

oleq commented Apr 15, 2020

jodator added a commit to ckeditor/ckeditor5-table that referenced this issue Apr 23, 2020
Feature: Introduce custom keyboard navigation through tables. Closes ckeditor/ckeditor5#3267. Closes ckeditor/ckeditor5#3286.
mlewand pushed a commit that referenced this issue May 1, 2020
Feature: Introduce custom keyboard navigation through tables. Closes #3267. Closes #3286.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:table type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants