Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two undo steps on delete #307

Closed
fredck opened this issue Aug 22, 2016 · 3 comments
Closed

Two undo steps on delete #307

fredck opened this issue Aug 22, 2016 · 3 comments
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@fredck
Copy link
Contributor

fredck commented Aug 22, 2016

  1. Go to the online demo.
  2. Double-click on "CKEditor" in the title to select the work.
  3. Backspace to "Delete".
  4. Cmd+Z to "Undo". Issue: There is only a selection change.
  5. Cmd+Z again. The deletion is undone.
@fredck
Copy link
Contributor Author

fredck commented Aug 22, 2016

Something similar happens with different variations of selection, like selecting one whole paragraph.

@Reinmar Reinmar added type:bug This issue reports a buggy (incorrect) behavior. status:confirmed labels Aug 22, 2016
@Reinmar Reinmar added this to the iteration 3 milestone Aug 22, 2016
@Reinmar
Copy link
Member

Reinmar commented Aug 22, 2016

I've encountered it myself as well and forgot to report. Most likely this issue will need to be moved to ckeditor5-delete, but there's a chance that it's an issue in ckeditor5-undo, so I'm leaving it here.

@Reinmar
Copy link
Member

Reinmar commented Sep 28, 2016

Already fixed. Most likely in ckeditor/ckeditor5-typing#42.

@Reinmar Reinmar closed this as completed Sep 28, 2016
@Reinmar Reinmar removed this from the iteration 3 milestone Sep 28, 2016
@Reinmar Reinmar added this to the iteration 3 milestone Sep 28, 2016
mlewand pushed a commit that referenced this issue May 1, 2020
Internal: The "Merge cells" split button should always be enabled to improve discoverability of tools in the dropdown. Closes #6631.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

2 participants