Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the "set anchor" feature / Bookmarks #1944

Closed
kleinph opened this issue Aug 7, 2019 · 68 comments · Fixed by #17278
Closed

Introduce the "set anchor" feature / Bookmarks #1944

kleinph opened this issue Aug 7, 2019 · 68 comments · Fixed by #17278
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. Epic squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@kleinph
Copy link

kleinph commented Aug 7, 2019

Is this a bug report or feature request? (choose one)

🆕 Feature request

Create a feature that allows the user to insert an anchor to the document, just like in CKEditor 4.
Screenshot 2022-05-02 at 09 37 37

Screenshot 2022-05-02 at 09 38 10


If you'd like to see this feature implemented, add 👍 to this post.

@Mgsy Mgsy changed the title Replacement for "set anchor" feature Introduce the "set anchor" feature Aug 22, 2019
@Mgsy Mgsy added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). labels Aug 22, 2019
@Mgsy
Copy link
Member

Mgsy commented Aug 22, 2019

Hi, thanks for the report. I've converted your ticket to a feature request.

@Mgsy Mgsy added this to the backlog milestone Aug 22, 2019
@jswiderski jswiderski added the support:2 An issue reported by a commercially licensed client. label Sep 15, 2020
@meecect
Copy link

meecect commented Feb 17, 2021

I've been trying to write a plugin using the downcast converter to automatically add an anchor tags to heading tags.

I can't get it to work...in the interim before this feature request is finished, could someone help with the code requried for this? I have followed the docs and have been able to add classses, set attributes, etc, but wheh I try to insert elements, it doesn't seem to work.

Could you give an example of how one could add the linkHref attribute to the text inside a heading tag in a downcast action?

Or, alternatively, (perhaps better), could one create a blank text element with an href attribute and append (or prepend) it to the heading1 element in a downcast action?

@Reinmar Reinmar added domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. and removed domain:v4-compatibilty labels Mar 9, 2021
@giovannidias1
Copy link

any news for this feature?

@aborkhovych
Copy link

+1 to this feature request

@523299338
Copy link

+2 to this feature request

@wimleers
Copy link

Drupal would also benefit from this feature: https://www.drupal.org/project/ckeditor5/issues/3224256.

@Reinmar Reinmar added squad:core Issue to be handled by the Core team. and removed squad:compat labels Sep 27, 2021
@hools18
Copy link

hools18 commented Sep 30, 2021

+1 to this feature request

@PTWvL
Copy link

PTWvL commented Oct 1, 2021

Google brought me here. +1 for this request

@dpf-dd
Copy link

dpf-dd commented Nov 22, 2021

#meetoo <3

@vlyalkobixal
Copy link

+1 for this too

@pomek pomek removed this from the backlog milestone Feb 21, 2022
@shootlens
Copy link

+4 for this feature request

@Barik85
Copy link

Barik85 commented May 3, 2022

+1 for this feature request

@cmak9149
Copy link

+1

1 similar comment
@venmathiraj
Copy link

+1

@ferrlen
Copy link

ferrlen commented Jun 26, 2022

Is there any progress being made on this issue? I'd like to use CKEditor 5 in my app, but this is a dealbreaker.

It's not particularly hard to implement this feature. I thought of creating a plugin to add anchors, but this wouldn't make much of a difference because links in CKEditor seem to always open in a new window, which is not the behaviour I want. I just want the user to be able to scroll to the desired point in the text.

Edit: it seems it's actually possible to change the behaviour when clicking links https://ckeditor.com/docs/ckeditor5/latest/features/link.html . But honestly at this point it's easier to simply pick another text editor that already has these features set

@amandine-ls
Copy link

+1

@goPOSTALman
Copy link

Still waiting on this to be added since 2020... wooo!

@dwandeljanicka
Copy link

dwandeljanicka commented Aug 7, 2024

Hi! We have started working on Anchors, and we would like to know your opinion to choose the most useful solution.

How should the anchor be displayed in the editor? Vote with emoji:

🚀 Inline (as it was in CKEditor 4) 

Zrzut ekranu 2024-07-22 o 14 20 01

🎉 Out of the text editing area 

Zrzut ekranu 2024-08-7 o 09 19 42
Zrzut ekranu 2024-08-7 o 15 30 36

👀 I don't need to see the anchors in the editor; it is enough that I can add links to them

@abigail1309
Copy link

abigail1309 commented Aug 7, 2024 via email

@raq007
Copy link

raq007 commented Aug 7, 2024 via email

@joegl
Copy link

joegl commented Aug 7, 2024

🚀

2 similar comments
@NIWm
Copy link

NIWm commented Aug 27, 2024

🚀

@SimonChabrier
Copy link

🚀

@SimonChabrier
Copy link

When will the feature be available please ?

@Witoso Witoso changed the title Introduce the "set anchor" feature Introduce the "set anchor" feature / Bookmarks Sep 9, 2024
@Witoso
Copy link
Member

Witoso commented Sep 9, 2024

We are working on this initiative right now. Most likely it will be done in 3 stages, though released together. I will update this comment with the links to more details as we go.

After the research, we decided that creating reference links will be called Bookmarks to be more content-creator friendly, and aligned with the most popular systems.

@Witoso
Copy link
Member

Witoso commented Oct 8, 2024

The work on bookmarks progresses quite nicely, and we decided to make a release of it without waiting for linking experience improvements (see scope in the comment) That way, you will be able to use the plugin earlier. TBD still on the exact release date.

But there's a second part that we will be focusing on immediately afterward: linking improvements and linking to bookmarks (#17230). I added a few UI prototypes how improved linking balloon may look like, and which areas will change. Please don't hesitate to leave your comments on the issue 😊

@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Oct 17, 2024
@arkflpc arkflpc added this to the iteration 80 milestone Oct 24, 2024
arkflpc added a commit that referenced this issue Oct 24, 2024
Feature (bookmark): Introduces the Bookmarks feature. Closes #1944.

Fix (list): Inserting or dropping a paragraph after the end of a list should not convert the paragraph to a list item. Closes #17224.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 24, 2024
@Witoso
Copy link
Member

Witoso commented Oct 24, 2024

Hey, we've finished the main work. This is planned for release but for the next iteration. We've just started testing phase for a bug fix release (planned for beginning of November). This is scheduled for the next one (~beginning of December).

Meanwhile, we continue to work on linking improvements and linking to bookmarks (#17230).

@dalin-
Copy link

dalin- commented Nov 5, 2024

I love getting a native implementation into CKEditor5. I have one suggestion, but I've never posted something in this community, so I have no idea how you do things.

If the new implementation matches what's shown in the screenshots in the OP description, then there's some UX issues that you might consider addressing before this goes out. The main issue is that you've got to know a lot about the underlying mechanics of anchors before you're able to use this thing. Most users on most sites won't know enough to be able to make use of this.

Here's a suggestion for the pop-up window.

Feel free to run with this, turn it into a new issue, or whatever fits best around here.


Use an anchor to link to a section within a page (not just the top):

Anchor name
⊏ニニニニニニニニニニ⊐ ✓ ⨯

To link to this anchor from within the current page: Don't use the full URL. Instead use a number sign followed by the name of the anchor.
#[anchor-name]
From another page: Use the full URL of this page followed by a number sign and the name of the anchor.


Ideally [anchor-name] populates automatically as the user types in the text box. The ⎘ icon should act as a button to copy the anchor to the clipboard. But both of these could be moved to follow-up issues if necessary.

@Witoso
Copy link
Member

Witoso commented Nov 7, 2024

@dalin- thanks for the feedback!

We will release the bookmarks without those, but I will make sure to mention in the docs that it's a feature v1 without all final touches. The final UI is connected with the #17230 where the list of bookmarks to link to will be automatically prefilled. We also will provide integrators to create their lists (bookmarks on other pages, for example).

I believe that informative descriptions should be the last resort for intuitive user interfaces, as they make the visuals bloated and the text has always the possibility of being misinterpreted. We also have tons of different use cases that the editor is used in, and we need to be careful about writing copy that may not be relevant for some of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. Epic squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.